Autofill menu item's labels on page change#112
Open
iamstratos wants to merge 1 commit intotsiger:masterfrom
Open
Autofill menu item's labels on page change#112iamstratos wants to merge 1 commit intotsiger:masterfrom
iamstratos wants to merge 1 commit intotsiger:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Creating a menu item will set the
labelto "New Item" or "New Child".Then, you have to edit the
labelmanually once you set a page.Solution
Menu item's
labelwill now change to the assign page's one if:If it was anything else, it won't change.
Also, moved the default texts to
menuUtils.jsfile as shared constants.Potential issue:
If a user intentionally sets the label to exactly "New Item" or "New Child" and then picks an internal page, we'd still overwrite with page.label. That’s rare but possible.